This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
docs: replace zeros comments with ones #28372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original comment is arguably correct. While the base58-encoded string representation of the default PublicKey is all ones, the underlying |
|
@CriesofCarrots yeah! Thanks for the quick reply and helpful comment. What do you think? |
Codecov Report
@@ Coverage Diff @@
## master #28372 +/- ##
=========================================
+ Coverage 77.3% 77.5% +0.1%
=========================================
Files 55 55
Lines 2889 2926 +37
Branches 402 407 +5
=========================================
+ Hits 2234 2268 +34
- Misses 514 517 +3
Partials 141 141 |
CriesofCarrots
approved these changes
Oct 13, 2022
This was referenced Nov 9, 2022
This was referenced Nov 28, 2022
This was referenced Dec 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation describes PublicKey.default as "all zeros" when its in fact, "all ones"